Page MenuHomePhabricator

[Flow202][lib][skip-ci] [25/23] Fix Flow issues from Kamil's recently landed diffs
ClosedPublic

Authored by ashoat on Nov 7 2023, 7:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 1:08 AM
Unknown Object (File)
Sun, Oct 27, 10:19 PM
Unknown Object (File)
Sun, Oct 27, 10:18 PM
Unknown Object (File)
Sun, Oct 27, 10:02 PM
Unknown Object (File)
Sep 29 2024, 2:45 AM
Unknown Object (File)
Sep 29 2024, 2:11 AM
Unknown Object (File)
Sep 6 2024, 9:45 PM
Unknown Object (File)
Sep 6 2024, 5:36 PM
Subscribers

Details

Summary

It's hard since you're not running the new Flow, but going forward would appreciate if you could try to make sure to parameterize all tShape and React.use* calls to avoid introducing new work for me.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9748

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat retitled this revision from [Flow202][lib] [24/23] Fix Flow issues from Kamil's recently landed diffs to [Flow202][lib] [25/23] Fix Flow issues from Kamil's recently landed diffs.Nov 7 2023, 7:01 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 7 2023, 7:11 AM
Harbormaster failed remote builds in B23865: Diff 32893!
ashoat requested review of this revision.Nov 7 2023, 7:16 AM

Thanks, I'll try to follow the new Flow rules

This revision is now accepted and ready to land.Nov 7 2023, 8:25 AM
ashoat retitled this revision from [Flow202][lib] [25/23] Fix Flow issues from Kamil's recently landed diffs to [Flow202][lib][skip-ci] [25/23] Fix Flow issues from Kamil's recently landed diffs.
This revision was landed with ongoing or failed builds.Nov 27 2023, 3:25 PM
This revision was automatically updated to reflect the committed changes.