Page MenuHomePhabricator

[Flow202][keyserver][skip-ci] [22/x] Address type errors with getWNSToken
ClosedPublic

Authored by ashoat on Nov 13 2023, 3:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 4:13 PM
Unknown Object (File)
Sun, Nov 10, 6:58 AM
Unknown Object (File)
Sat, Nov 9, 4:55 PM
Unknown Object (File)
Fri, Nov 8, 6:02 PM
Unknown Object (File)
Fri, Nov 8, 4:32 AM
Unknown Object (File)
Fri, Nov 8, 1:57 AM
Unknown Object (File)
Sep 28 2024, 10:51 PM
Unknown Object (File)
Sep 28 2024, 10:51 PM
Subscribers

Details

Summary

The new version of Flow seems to be worried that the value of wnsAccessToken will change between when it is being checked and when it's used. This diff assigns the value to a local variable before checking it, which Flow seems to prefer.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9870

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 13 2023, 3:42 PM
Harbormaster failed remote builds in B24088: Diff 33187!
This revision is now accepted and ready to land.Nov 15 2023, 1:24 AM
ashoat retitled this revision from [Flow202][keyserver] [22/x] Address type errors with getWNSToken to [Flow202][keyserver][skip-ci] [22/x] Address type errors with getWNSToken.Nov 19 2023, 5:09 PM
This revision was landed with ongoing or failed builds.Nov 27 2023, 3:27 PM
This revision was automatically updated to reflect the committed changes.