Page MenuHomePhabricator

[Flow202][native][skip-ci] [49/x] Make permissions array mutable in android-permissions.js
ClosedPublic

Authored by ashoat on Nov 27 2023, 1:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 6:41 AM
Unknown Object (File)
Thu, Oct 24, 7:01 AM
Unknown Object (File)
Thu, Oct 17, 10:41 AM
Unknown Object (File)
Thu, Oct 17, 10:41 AM
Unknown Object (File)
Thu, Oct 17, 10:41 AM
Unknown Object (File)
Thu, Oct 17, 10:41 AM
Unknown Object (File)
Sep 6 2024, 1:46 AM
Unknown Object (File)
Sep 6 2024, 1:46 AM
Subscribers

Details

Summary

Flow was printing an error because in fact the type for PermissionsAndroid.requestMultiple takes an Array rather than a $ReadOnlyArray. I suspect this is an error on the part of the React Native team, but to avoid any issues I updated our types to use Array as well.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10032

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable