Page MenuHomePhabricator

[Flow202][web][skip-ci] [15/x] Fix Flow issues in htmlTargetFromEvent
ClosedPublic

Authored by ashoat on Nov 8 2023, 11:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 12, 2:18 PM
Unknown Object (File)
Tue, May 7, 3:50 AM
Unknown Object (File)
Sat, May 4, 3:25 AM
Unknown Object (File)
Wed, May 1, 2:00 PM
Unknown Object (File)
Fri, Apr 26, 3:29 PM
Unknown Object (File)
Sun, Apr 21, 11:40 PM
Unknown Object (File)
Mon, Apr 15, 8:48 PM
Unknown Object (File)
Apr 14 2024, 8:02 AM
Subscribers

Details

Summary

This is a really old utility. We only use it in web/calendar/day.react.js now.

Besides adding some types, I also had to add an invariant. The old code would've crashed in this case anyways (on the other invariant), but the second invariant was necessary for Flow.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9780

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2023, 12:03 PM
Harbormaster failed remote builds in B23929: Diff 32967!
This revision is now accepted and ready to land.Nov 9 2023, 3:11 AM
ashoat retitled this revision from [Flow202][web] [15/x] Fix Flow issues in htmlTargetFromEvent to [Flow202][web][skip-ci] [15/x] Fix Flow issues in htmlTargetFromEvent.Nov 19 2023, 5:03 PM
This revision was landed with ongoing or failed builds.Nov 27 2023, 3:26 PM
This revision was automatically updated to reflect the committed changes.