Page MenuHomePhabricator

[Flow202][native][skip-ci] [33/x] Fix Flow issues with React hooks being underconstrained
ClosedPublic

Authored by ashoat on Nov 27 2023, 12:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 7:17 AM
Unknown Object (File)
Oct 17 2024, 11:49 AM
Unknown Object (File)
Oct 17 2024, 11:49 AM
Unknown Object (File)
Oct 17 2024, 11:49 AM
Unknown Object (File)
Oct 17 2024, 11:49 AM
Unknown Object (File)
Sep 6 2024, 2:31 AM
Unknown Object (File)
Sep 6 2024, 2:31 AM
Unknown Object (File)
Sep 6 2024, 2:31 AM
Subscribers

Details

Summary

The new version of Flow is requiring declarations to provide explicit type params when Flow isn't able to infer them.

This diff adds those declarations for React.useRef and React.useState calls.

This is the native equivalent of D9773 (web) and D9693 (lib).

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10016

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable