Page MenuHomePhabricator

[Flow202][native][skip-ci] [60/x] Fix type error in FFmpeg
ClosedPublic

Authored by ashoat on Nov 27 2023, 1:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 6:41 AM
Unknown Object (File)
Oct 26 2024, 8:16 PM
Unknown Object (File)
Oct 26 2024, 8:16 PM
Unknown Object (File)
Oct 26 2024, 8:15 PM
Unknown Object (File)
Oct 26 2024, 8:15 PM
Unknown Object (File)
Oct 26 2024, 8:15 PM
Unknown Object (File)
Oct 17 2024, 10:41 AM
Unknown Object (File)
Oct 17 2024, 10:41 AM
Subscribers

Details

Summary

Initially Flow was complaining on line 70 because this.currentCalls is keyed on QueuedCommandType, not string. After I fixed that, Flow started complaining on line 69 due to invalid-computed-prop (computed props must be string or number), so I added a cast to string.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10043

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable