[Flow202][web][skip-ci] [6/x] Address type errors in community drawer code
ClosedPublic
Actions

Authored by ashoat on Nov 8 2023, 11:34 AM.

Details

Reviewers

inka

Commits

rCOMM2aeb3f4112bc: [Flow202][web][skip-ci] [6/x] Address type errors in community drawer code

Summary

The new version of Flow revealed some type errors here. Submitting this as a separate diff to make sure the changes I made to correct the type errors are correct.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9771

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 8 2023, 11:34 AM

Herald added subscribers: will, tomek. · View Herald TranscriptNov 8 2023, 11:34 AM

ashoat added inline comments.Nov 8 2023, 11:35 AM

web/sidebar/community-drawer-item-community.react.js
32 ↗	(On Diff #32958)	Note that I deleted this line
web/sidebar/community-drawer-item.react.js
39 ↗	(On Diff #32958)	Note that I added this line

ashoat added a child revision: D9773: [Flow202][web][skip-ci] [7/x] Fix Flow issues with React hooks being underconstrained.Nov 8 2023, 11:35 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2023, 11:45 AM

Harbormaster failed remote builds in B23920: Diff 32958!

ashoat requested review of this revision.Nov 8 2023, 11:46 AM

inka accepted this revision.Nov 9 2023, 4:15 AM

This revision is now accepted and ready to land.Nov 9 2023, 4:15 AM

ashoat retitled this revision from [Flow202][web] [6/x] Address type errors in community drawer code to [Flow202][web][skip-ci] [6/x] Address type errors in community drawer code.Nov 19 2023, 5:01 PM

This revision was landed with ongoing or failed builds.Nov 27 2023, 3:26 PM

Closed by commit rCOMM2aeb3f4112bc: [Flow202][web][skip-ci] [6/x] Address type errors in community drawer code (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM2aeb3f4112bc: [Flow202][web][skip-ci] [6/x] Address type errors in community drawer code.