[Flow202][web][skip-ci] [7/x] Fix Flow issues with React hooks being underconstrained
ClosedPublic
Actions

Authored by ashoat on Nov 8 2023, 11:35 AM.

Details

Reviewers

atul

Commits

rCOMM7374240871d7: [Flow202][web][skip-ci] [7/x] Fix Flow issues with React hooks being…

Summary

The new version of Flow is requiring declarations to provide explicit type params when Flow isn't able to infer them.

This diff adds those declarations for React.useRef and React.useState calls.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9772

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 8 2023, 11:35 AM

Herald added subscribers: will, tomek. · View Herald TranscriptNov 8 2023, 11:35 AM

ashoat added a child revision: D9774: [Flow202][web][skip-ci] [8/x] Fix Flow issues with types of variables that get mutated.Nov 8 2023, 11:36 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2023, 11:47 AM

Harbormaster failed remote builds in B23921: Diff 32959!

ashoat requested review of this revision.Nov 8 2023, 11:48 AM

Rebase

Harbormaster failed remote builds in B23953: Diff 33005!Nov 9 2023, 5:40 AM

atul accepted this revision.Nov 9 2023, 11:44 AM

This revision is now accepted and ready to land.Nov 9 2023, 11:44 AM

ashoat retitled this revision from [Flow202][web] [7/x] Fix Flow issues with React hooks being underconstrained to [Flow202][web][skip-ci] [7/x] Fix Flow issues with React hooks being underconstrained.Nov 19 2023, 5:02 PM

Rebase

Harbormaster completed remote builds in B24262: Diff 33400.Nov 19 2023, 5:39 PM

ashoat mentioned this in D10017: [Flow202][native][skip-ci] [33/x] Fix Flow issues with React hooks being underconstrained.Nov 27 2023, 12:52 AM

Closed by commit rCOMM7374240871d7: [Flow202][web][skip-ci] [7/x] Fix Flow issues with React hooks being… (authored by ashoat). · Explain WhyNov 27 2023, 3:26 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM7374240871d7: [Flow202][web][skip-ci] [7/x] Fix Flow issues with React hooks being….

ashoat mentioned this in rCOMM0cc4fc0638e0: [Flow202][native][skip-ci] [33/x] Fix Flow issues with React hooks being….Nov 27 2023, 3:28 PM