Page MenuHomePhabricator

[Flow202][web][skip-ci] [17/x] Fix Flow issues in commReduxStorageEngine
ClosedPublic

Authored by ashoat on Nov 8 2023, 11:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 8:32 PM
Unknown Object (File)
Thu, Nov 14, 9:08 PM
Unknown Object (File)
Sun, Oct 27, 9:02 PM
Unknown Object (File)
Thu, Oct 24, 4:46 AM
Unknown Object (File)
Oct 19 2024, 2:38 AM
Unknown Object (File)
Oct 19 2024, 2:38 AM
Unknown Object (File)
Oct 19 2024, 2:38 AM
Unknown Object (File)
Oct 19 2024, 2:33 AM
Subscribers

Details

Summary

The new version of Flow does not realize that typeof result.item !== 'string' will be false if result isn't set, so we need to add a separate check for this.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9782

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2023, 12:06 PM
Harbormaster failed remote builds in B23931: Diff 32969!
This revision is now accepted and ready to land.Nov 9 2023, 5:23 AM
ashoat retitled this revision from [Flow202][web] [17/x] Fix Flow issues in commReduxStorageEngine to [Flow202][web][skip-ci] [17/x] Fix Flow issues in commReduxStorageEngine.Nov 19 2023, 5:04 PM
This revision was landed with ongoing or failed builds.Nov 27 2023, 3:26 PM
This revision was automatically updated to reflect the committed changes.