Paths

Table of Contentst

Differential D9691

[RN72][skip-ci] Update Flow to 0.202.1
ClosedPublic
Actions

Authored by ashoat on Nov 4 2023, 11:52 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 30, 8:40 AM

	Unknown Object (File)
	Sun, Apr 28, 2:26 AM

	Unknown Object (File)
	Fri, Apr 26, 5:56 AM

	Unknown Object (File)
	Thu, Apr 25, 5:05 PM

	Unknown Object (File)
	Thu, Apr 25, 1:14 PM

	Unknown Object (File)
	Tue, Apr 16, 6:00 PM

	Unknown Object (File)
	Mon, Apr 15, 8:45 PM

	Unknown Object (File)
	Apr 14 2024, 7:45 AM

View All 32 Files

Subscribers

Details

Reviewers

tomek
bartek
atul
• jon

Commits

rCOMMde1aac8620c6: [RN72][skip-ci] Update Flow to 0.202.1

Summary

The first thing I'm working on is fixing Flow errors with the new version of Flow, so I'll start by upgrading Flow.

The new version of Flow adds support for enums, which I'm enabling here based on the lead of the React Native .flowconfig.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9690

Test Plan

The eventual test plan is to run the [iOS, Android] apps in [debug, release] on [simulator, physical device] and to play around with a bunch of the screens and make sure things generally work

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 4 2023, 11:52 AM

Herald added a reviewer: • jon. · View Herald TranscriptNov 4 2023, 11:52 AM

Herald added a subscriber: will. · View Herald Transcript

ashoat added a child revision: D9692: [Flow202][lib][skip-ci] [0/23] Fix Flow issues relating to unsealed objects.Nov 4 2023, 11:53 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 4 2023, 12:03 PM

Harbormaster failed remote builds in B23733: Diff 32695!

ashoat requested review of this revision.Nov 4 2023, 12:15 PM

ashoat added a child revision: D9716: [Flow202][electron-update-server][skip-ci] [1/3] Make sure we don't run Prettier on flow-typed folders.Nov 5 2023, 8:13 AM

atul accepted this revision.Nov 5 2023, 10:17 AM

This revision is now accepted and ready to land.Nov 5 2023, 10:17 AM

bartek accepted this revision.Nov 6 2023, 1:16 AM

ashoat retitled this revision from [RN72] Update Flow to 0.202.1 to [RN72][skip-ci] Update Flow to 0.202.1.Nov 19 2023, 11:41 AM

ashoat removed a parent revision: D9690: [RN72][skip-ci] Update React Native and React package versions.Nov 27 2023, 12:15 AM

This revision was landed with ongoing or failed builds.Nov 27 2023, 3:24 PM

Closed by commit rCOMMde1aac8620c6: [RN72][skip-ci] Update Flow to 0.202.1 (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMde1aac8620c6: [RN72][skip-ci] Update Flow to 0.202.1.

Revision Contents
Changeset List

Path

Size

desktop/

1 line

2 lines

keyserver/

2 lines

2 lines

landing/

1 line

2 lines

lib/

2 lines

2 lines

native/

4 lines

2 lines

services/

electron-update-server/

1 line

2 lines

web/

1 line

2 lines

8 lines

Diff 33787

desktop/.flowconfig

Loading...

desktop/package.json

Loading...

keyserver/.flowconfig

Loading...

keyserver/package.json

Loading...

landing/.flowconfig

Loading...

landing/package.json

Loading...

lib/.flowconfig

Loading...

lib/package.json

Loading...

native/.flowconfig

Loading...

native/package.json

Loading...

services/electron-update-server/.flowconfig

Loading...

services/electron-update-server/package.json

Loading...

web/.flowconfig

Loading...

web/package.json

Loading...

yarn.lock

Loading...