Page MenuHomePhabricator

[Flow202][keyserver][skip-ci] [19/x] Fix Flow issues with collection lookup that doesn't match type
ClosedPublic

Authored by ashoat on Nov 13 2023, 3:24 PM.
Tags
None
Referenced Files
F3173346: D9868.id33184.diff
Thu, Nov 7, 3:19 PM
Unknown Object (File)
Thu, Oct 17, 11:43 AM
Unknown Object (File)
Thu, Oct 17, 11:39 AM
Unknown Object (File)
Sep 29 2024, 3:22 AM
Unknown Object (File)
Sep 29 2024, 3:22 AM
Unknown Object (File)
Sep 29 2024, 3:21 AM
Unknown Object (File)
Sep 29 2024, 3:10 AM
Unknown Object (File)
Aug 28 2024, 7:24 AM
Subscribers
None

Details

Summary

The new version of Flow forced me to type this collection, which revealed a type error.

The issue is that Flow doesn't want us to call validProxies.has with a type that doesn't match the indexer. Since proxy is nullable, we first need to check if it's set before calling validProxies.has.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9867

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 13 2023, 3:37 PM
Harbormaster failed remote builds in B24085: Diff 33184!
This revision is now accepted and ready to land.Nov 14 2023, 8:47 AM
ashoat retitled this revision from [Flow202][keyserver] [19/x] Fix Flow issues with collection lookup that doesn't match type to [Flow202][keyserver][skip-ci] [19/x] Fix Flow issues with collection lookup that doesn't match type.Nov 19 2023, 5:08 PM
This revision was landed with ongoing or failed builds.Nov 27 2023, 3:27 PM
This revision was automatically updated to reflect the committed changes.