Page MenuHomePhabricator

[Flow202][native][skip-ci] [11/x] Add type params to ReactNav createMaterialTopTabNavigator call
ClosedPublic

Authored by ashoat on Nov 27 2023, 12:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 2:08 AM
Unknown Object (File)
Sun, Oct 27, 6:16 PM
Unknown Object (File)
Sep 30 2024, 1:18 AM
Unknown Object (File)
Sep 30 2024, 1:14 AM
Unknown Object (File)
Sep 29 2024, 1:53 AM
Unknown Object (File)
Sep 29 2024, 1:53 AM
Unknown Object (File)
Sep 29 2024, 1:51 AM
Unknown Object (File)
Sep 29 2024, 1:41 AM
Subscribers
None

Details

Summary

The new version of Flow is pushing us to specify all of these type params. Presumably Flow was always unable to infer them, but the new version is stricter about forcing type params when they can't be inferred.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9994

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable