Page MenuHomePhabricator

[Flow202][keyserver][skip-ci] [18/x] Fix Flow issues with baseGetENSNames.bind
ClosedPublic

Authored by ashoat on Nov 13 2023, 3:22 PM.
Tags
None
Referenced Files
F3525437: D9867.diff
Mon, Dec 23, 5:01 PM
Unknown Object (File)
Sun, Dec 15, 11:58 PM
Unknown Object (File)
Sun, Dec 15, 11:58 PM
Unknown Object (File)
Sun, Dec 15, 11:57 PM
Unknown Object (File)
Sun, Dec 15, 11:49 PM
Unknown Object (File)
Sun, Dec 15, 5:45 PM
Unknown Object (File)
Nov 22 2024, 10:12 PM
Unknown Object (File)
Nov 22 2024, 9:19 PM
Subscribers

Details

Summary

This is the keyserver equivalent of D9696. Flow doesn't seem to like this construction anymore: https://gist.github.com/Ashoat/f5b3517c46331ecae6870d91cae7ddd2

I couldn't figure out a way to get rid of the type errors while keeping the bind call. Instead, I just decided to declare a new function.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9866

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 13 2023, 3:35 PM
Harbormaster failed remote builds in B24084: Diff 33183!
This revision is now accepted and ready to land.Nov 14 2023, 12:45 PM
ashoat retitled this revision from [Flow202][keyserver] [18/x] Fix Flow issues with baseGetENSNames.bind to [Flow202][keyserver][skip-ci] [18/x] Fix Flow issues with baseGetENSNames.bind.Nov 19 2023, 5:08 PM
This revision was landed with ongoing or failed builds.Nov 27 2023, 3:27 PM
This revision was automatically updated to reflect the committed changes.