Page MenuHomePhabricator

[Flow202][keyserver][skip-ci] [8/x] Address type errors in createPersonalThreads calling createThread
ClosedPublic

Authored by ashoat on Nov 13 2023, 3:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 8:54 PM
Unknown Object (File)
Sun, Oct 20, 8:56 AM
Unknown Object (File)
Sep 29 2024, 12:51 AM
Unknown Object (File)
Sep 29 2024, 12:51 AM
Unknown Object (File)
Sep 29 2024, 12:51 AM
Unknown Object (File)
Sep 29 2024, 12:40 AM
Unknown Object (File)
Sep 28 2024, 6:25 AM
Unknown Object (File)
Sep 28 2024, 4:44 AM
Subscribers

Details

Summary

In D8507, I update createThread so that it no longer returns newThreadInfo anymore, following the deprecation of some old client codeVersions.

At the time I should've also updated this code. The Flow upgrade forced me to type it, which then uncovered an error when checking for newThreadInfo, since it was removed from the type in D8507.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9855

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 13 2023, 3:11 PM
Harbormaster failed remote builds in B24073: Diff 33171!
This revision is now accepted and ready to land.Nov 15 2023, 5:03 AM
ashoat retitled this revision from [Flow202][keyserver] [8/x] Address type errors in createPersonalThreads calling createThread to [Flow202][keyserver][skip-ci] [8/x] Address type errors in createPersonalThreads calling createThread.Nov 19 2023, 5:06 PM
This revision was landed with ongoing or failed builds.Nov 27 2023, 3:26 PM
This revision was automatically updated to reflect the committed changes.