Differential D9717 Authored by ashoat on Nov 5 2023, 6:58 AM.
Details Summary The electron-update-server one has some newer changes from upstream, but the keyserver one has our sameSite change. NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version o
f Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.
Depends on D9716 Test Plan Make sure no additional Flow error introduced on keyserver or electron-update-server
Diff Detail
Event TimelineHerald added a reviewer: • jon. · View Herald TranscriptNov 5 2023, 6:58 AM2023-11-05 06:58:29 (UTC-8) Harbormaster returned this revision to the author for changes because remote builds failed.Nov 5 2023, 7:09 AM2023-11-05 07:09:07 (UTC-8) This revision is now accepted and ready to land.Nov 6 2023, 1:30 AM2023-11-06 01:30:42 (UTC-8) ashoat retitled this revision from [Flow202][electron-update-server] [2/3] Use the same flow-typed libdef for express throughout our codebase to [Flow202][electron-update-server][skip-ci] [2/3] Use the same flow-typed libdef for express throughout our codebase.Nov 19 2023, 11:43 AM2023-11-19 11:43:33 (UTC-8) This revision was landed with ongoing or failed builds.Nov 27 2023, 3:25 PM2023-11-27 15:25:49 (UTC-8) Closed by commit rCOMM558275869302: [Flow202][electron-update-server][skip-ci] [2/3] Use the same flow-typed libdef… (authored by ashoat). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 33815 |