Page MenuHomePhabricator

[Flow202][electron-update-server][skip-ci] [2/3] Use the same flow-typed libdef for express throughout our codebase
ClosedPublic

Authored by ashoat on Nov 5 2023, 6:58 AM.
Tags
None
Referenced Files
F3349434: D9717.diff
Fri, Nov 22, 6:00 PM
Unknown Object (File)
Sun, Nov 10, 2:45 PM
Unknown Object (File)
Fri, Nov 8, 1:51 AM
Unknown Object (File)
Thu, Nov 7, 2:47 AM
Unknown Object (File)
Sun, Oct 27, 5:51 PM
Unknown Object (File)
Sep 28 2024, 10:52 PM
Unknown Object (File)
Sep 28 2024, 10:52 PM
Unknown Object (File)
Sep 28 2024, 10:48 PM
Subscribers

Details

Summary

The electron-update-server one has some newer changes from upstream, but the keyserver one has our sameSite change.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version o f Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9716

Test Plan

Make sure no additional Flow error introduced on keyserver or electron-update-server

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 5 2023, 7:09 AM
Harbormaster failed remote builds in B23759: Diff 32721!
ashoat requested review of this revision.Nov 5 2023, 7:53 AM
This revision is now accepted and ready to land.Nov 6 2023, 1:30 AM
ashoat retitled this revision from [Flow202][electron-update-server] [2/3] Use the same flow-typed libdef for express throughout our codebase to [Flow202][electron-update-server][skip-ci] [2/3] Use the same flow-typed libdef for express throughout our codebase.Nov 19 2023, 11:43 AM
This revision was landed with ongoing or failed builds.Nov 27 2023, 3:25 PM
This revision was automatically updated to reflect the committed changes.