Page MenuHomePhabricator

[Flow202][native][skip-ci] [53/x] Address type errors with Promise.all in InputStateContainer
ClosedPublic

Authored by ashoat on Nov 27 2023, 1:28 AM.
Tags
None
Referenced Files
F1744346: D10037.diff
Mon, May 13, 8:45 AM
Unknown Object (File)
Mar 5 2024, 7:19 AM
Unknown Object (File)
Mar 5 2024, 7:19 AM
Unknown Object (File)
Mar 5 2024, 7:19 AM
Unknown Object (File)
Mar 5 2024, 7:19 AM
Unknown Object (File)
Dec 17 2023, 2:15 AM
Unknown Object (File)
Dec 16 2023, 7:40 PM
Unknown Object (File)
Dec 16 2023, 4:24 AM
Subscribers

Details

Summary

The new version of Flow is fairly particular about Promise.all. I had to restructure this code to use async IIFEs.

Separating this out into its own diff because it required adding some exports in a different file.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10036

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable