Page MenuHomePhabricator
Differential D10015

[Flow202][native][skip-ci] [31/x] Address missing-local-annot type errors
ClosedPublic
Actions

Authored by ashoat on Nov 27 2023, 12:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 9:57 PM
Unknown Object (File)
Sun, Apr 21, 5:56 AM
Unknown Object (File)
Mar 5 2024, 7:43 AM
Unknown Object (File)
Mar 5 2024, 7:43 AM
Unknown Object (File)
Mar 5 2024, 7:43 AM
Unknown Object (File)
Mar 5 2024, 7:43 AM
Unknown Object (File)
Dec 13 2023, 6:49 PM
Unknown Object (File)
Dec 11 2023, 9:46 PM
View All 9 Files
Subscribers
None

Details

Reviewers
tomek
Commits
rCOMMdb14a28e300e: [Flow202][native][skip-ci] [31/x] Address missing-local-annot type errors
Summary

The new version of Flow wants more annotations for function and member definitions. This diff adds all of the required annotations to the native codebase necessary to clear all missing-local-annot errors.

This is the native equivalent of D9771 (web), D9697 (lib), and D9873 (keyserver).

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10014

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat requested review of this revision.Nov 27 2023, 12:50 AM
ashoat created this revision.
Harbormaster completed remote builds in B24456: Diff 33659.Nov 27 2023, 12:50 AM
ashoat added a child revision: D10016: [Flow202][native][skip-ci] [32/x] Fix type errors in OverlayNavigator.Nov 27 2023, 12:50 AM
tomek accepted this revision.Nov 27 2023, 6:57 AM
This revision is now accepted and ready to land.Nov 27 2023, 6:57 AM
ashoat retitled this revision from t b[Flow202][native][skip-ci] [31/x] Address missing-local-annot type errors to [Flow202][native][skip-ci] [31/x] Address missing-local-annot type errors.Nov 27 2023, 8:51 AM
ashoat edited the summary of this revision. (Show Details)
Closed by commit rCOMMdb14a28e300e: [Flow202][native][skip-ci] [31/x] Address missing-local-annot type errors (authored by ashoat). · Explain WhyNov 27 2023, 3:28 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMdb14a28e300e: [Flow202][native][skip-ci] [31/x] Address missing-local-annot type errors.

Revision Contents
Changeset List

PathSize
native/
account/
10 lines
4 lines
registration/
3 lines
12 lines
10 lines
avatars/
5 lines
calendar/
50 lines
2 lines
chat/
29 lines
8 lines
44 lines
2 lines
4 lines
2 lines
49 lines
7 lines
10 lines
3 lines
15 lines
8 lines
3 lines
3 lines
9 lines
settings/
2 lines
4 lines
3 lines
2 lines
8 lines
2 lines
4 lines
2 lines
4 lines
10 lines
2 lines
2 lines
955 lines
3 lines
23 lines
10 lines
2 lines
community-creation/
2 lines
components/
2 lines
30 lines
4 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
47 lines
2 lines
8 lines
6 lines
input/
31 lines
keyboard/
4 lines
media/
81 lines
20 lines
2 lines
8 lines
2 lines
2 lines
25 lines
navigation/
8 lines
8 lines
4 lines
9 lines
4 lines
8 lines
profile/
2 lines
2 lines
2 lines
2 lines
4 lines
2 lines
3 lines
7 lines
4 lines
3 lines
11 lines
4 lines
2 lines
push/
6 lines
redux/
11 lines
13 lines
89 lines
2 lines
roles/
3 lines
search/
2 lines
tooltip/
31 lines
utils/
19 lines

Diff 33899

View Options

native/account/logged-out-modal.react.js

Loading...
View Options

native/account/register-panel.react.js

Loading...
View Options

native/account/registration/emoji-avatar-selection.react.js

Loading...
View Options

native/account/siwe-hooks.js

Loading...
View Options

native/account/siwe-panel.react.js

Loading...
View Options

native/avatars/emoji-avatar-creation.react.js

Loading...
View Options

native/calendar/calendar.react.js

Loading...
View Options

native/calendar/section-footer.react.js

Loading...
View Options

native/chat/chat-input-bar.react.js

Loading...
View Options

native/chat/chat-list.react.js

Loading...
View Options

native/chat/chat.react.js

Loading...
View Options

native/chat/failed-send.react.js

Loading...
View Options

native/chat/message-list-container.react.js

Loading...
View Options

native/chat/message-list-header-title.react.js

Loading...
View Options

native/chat/message-list.react.js

Loading...
View Options

native/chat/message-reactions-modal.react.js

Loading...
View Options

native/chat/multimedia-message-multimedia.react.js

Loading...
View Options

native/chat/multimedia-message-tooltip-button.react.js

Loading...
View Options

native/chat/multimedia-message-tooltip-modal.react.js

Loading...
View Options

native/chat/multimedia-message.react.js

Loading...
View Options

native/chat/robotext-message-tooltip-button.react.js

Loading...
View Options

native/chat/robotext-message-tooltip-modal.react.js

Loading...
View Options

native/chat/robotext-message.react.js

Loading...
View Options

native/chat/settings/compose-subchannel-modal.react.js

Loading...
View Options

native/chat/settings/delete-thread.react.js

Loading...
View Options

native/chat/settings/emoji-thread-avatar-creation.react.js

Loading...
View Options

native/chat/settings/thread-settings-color.react.js

Loading...
View Options

native/chat/settings/thread-settings-description.react.js

Loading...
View Options

native/chat/settings/thread-settings-home-notifs.react.js

Loading...
View Options

native/chat/settings/thread-settings-leave-thread.react.js

Loading...
View Options

native/chat/settings/thread-settings-media-gallery.react.js

Loading...
View Options

native/chat/settings/thread-settings-member.react.js

Loading...
View Options

native/chat/settings/thread-settings-name.react.js

Loading...
View Options

native/chat/settings/thread-settings-promote-sidebar.react.js

Loading...
View Options

native/chat/settings/thread-settings-push-notifs.react.js

Loading...
View Options

native/chat/settings/thread-settings.react.js

Loading...
View Options

native/chat/text-message-tooltip-button.react.js

Loading...
View Options

native/chat/text-message-tooltip-modal.react.js

Loading...
View Options

native/chat/text-message.react.js

Loading...
View Options

native/chat/thread-settings-button.react.js

Loading...
View Options

native/community-creation/community-configuration.react.js

Loading...
View Options

native/components/emoji-keyboard.react.js

Loading...
View Options

native/components/full-screen-view-modal.react.js

Loading...
View Options

native/components/keyboard-avoiding-view.react.js

Loading...
View Options

native/components/link-button.react.js

Loading...
View Options

native/components/node-height-measurer.react.js

Loading...
View Options

native/components/selectable-text-input.react.ios.js

Loading...
View Options

native/components/selectable-text-input.react.js

Loading...
View Options

native/components/tag-input.react.js

Loading...
View Options

native/components/thread-list-thread.react.js

Loading...
View Options

native/components/thread-list.react.js

Loading...
View Options

native/components/user-list-user.react.js

Loading...
View Options

native/components/user-list.react.js

Loading...
View Options

native/crash.react.js

Loading...
View Options

native/input/input-state-container.react.js

Loading...
View Options

native/keyboard/keyboard-input-host.react.js

Loading...
View Options

native/media/camera-modal.react.js

Loading...
View Options

native/media/media-gallery-keyboard.react.js

Loading...
View Options

native/media/media-utils.js

Loading...
View Options

native/media/multimedia.react.js

Loading...
View Options

native/media/remote-image.react.js

Loading...
View Options

native/media/save-media.js

Loading...
View Options

native/media/video-playback-modal.react.js

Loading...
View Options

native/navigation/community-drawer-content.react.js

Loading...
View Options

native/navigation/nav-selectors.js

Loading...
View Options

native/navigation/orientation-handler.react.js

Loading...
View Options

native/navigation/root-navigator.react.js

Loading...
View Options

native/navigation/tab-bar.react.js

Loading...
View Options

native/navigation/tab-navigator.react.js

Loading...
View Options

native/profile/appearance-preferences.react.js

Loading...
View Options

native/profile/backup-menu.react.js

Loading...
View Options

native/profile/custom-server-modal.react.js

Loading...
View Options

native/profile/default-notifications-preferences.react.js

Loading...
View Options

native/profile/dev-tools.react.js

Loading...
View Options

native/profile/edit-password.react.js

Loading...
View Options

native/profile/emoji-user-avatar-creation.react.js

Loading...
View Options

native/profile/keyserver-selection-list.react.js

Loading...
View Options

native/profile/profile-screen.react.js

Loading...
View Options

native/profile/profile.react.js

Loading...
View Options

native/profile/relationship-list-item.react.js

Loading...
View Options

native/profile/relationship-list.react.js

Loading...
View Options

native/profile/toggle-report.react.js

Loading...
View Options

native/push/push-handler.react.js

Loading...
View Options

native/redux/client-db-utils.js

Loading...
View Options

native/redux/connectivity-updater.react.js

Loading...
View Options

native/redux/persist.js

Loading...
View Options

native/redux/update-roles-and-permissions.js

Loading...
View Options

native/roles/roles-navigator.react.js

Loading...
View Options

native/search/message-search.react.js

Loading...
View Options

native/tooltip/tooltip.react.js

Loading...
View Options

native/utils/typeahead-utils.js

Loading...