HomePhabricator
Diffusion Comm db14a28e300e

[Flow202][native][skip-ci] [31/x] Address missing-local-annot type errors

Description

[Flow202][native][skip-ci] [31/x] Address missing-local-annot type errors

Summary:
The new version of Flow wants more annotations for function and member definitions. This diff adds all of the required annotations to the native codebase necessary to clear all missing-local-annot errors.

This is the native equivalent of D9771 (web), D9697 (lib), and D9873 (keyserver).

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10014

Test Plan: Confirm the Flow errors go away

Reviewers: tomek

Reviewed By: tomek

Differential Revision: https://phab.comm.dev/D10015

Details

Provenance
ashoatAuthored on Nov 23 2023, 4:37 AM
Reviewer
tomek
Differential Revision
D10015: [Flow202][native][skip-ci] [31/x] Address missing-local-annot type errors
Parents
rCOMM39ed0a4e26b9: [Flow202][native][skip-ci] [30/x] Type PushHandler.
Branches
Unknown
Tags
Unknown