Differential D10014 Authored by ashoat on Nov 27 2023, 12:50 AM.
Details
Summary Separating this out because it requires exporting a type. NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.
Depends on D10013 Test Plan Confirm the Flow errors go away
Diff Detail
Event TimelineHerald added a subscriber: tomek. · View Herald TranscriptNov 27 2023, 12:50 AM2023-11-27 00:50:04 (UTC-8) Harbormaster completed remote builds in B24455: Diff 33658.Nov 27 2023, 12:50 AM2023-11-27 00:50:04 (UTC-8) ashoat added a child revision: D10015: [Flow202][native][skip-ci] [31/x] Address missing-local-annot type errors. This revision is now accepted and ready to land.Nov 27 2023, 4:30 AM2023-11-27 04:30:11 (UTC-8) Closed by commit rCOMM39ed0a4e26b9: [Flow202][native][skip-ci] [30/x] Type PushHandler. (authored by ashoat). · Explain WhyNov 27 2023, 3:28 PM2023-11-27 15:28:32 (UTC-8) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 33897 |