[Flow202][lib][skip-ci] [21/23] Fix Flow issues with iterating through chars in a string
ClosedPublic
Actions

Authored by ashoat on Nov 4 2023, 12:07 PM.

Details

Reviewers

tomek

Commits

rCOMM94a0833ef487: [Flow202][lib][skip-ci] [21/23] Fix Flow issues with iterating through chars in…

Summary

I was surprised to see an error here, so I made a GitHub issue on the Flow repo. Full context on this change can be seen there.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9712

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 4 2023, 12:07 PM

Herald added a subscriber: will. · View Herald TranscriptNov 4 2023, 12:07 PM

ashoat added a child revision: D9714: [Flow202][lib][skip-ci] [22/23] Fix Flow issues with untyped conversionFunctions in conversion-utils.js.Nov 4 2023, 12:07 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 4 2023, 12:41 PM

Harbormaster failed remote builds in B23755: Diff 32717!

ashoat requested review of this revision.Nov 4 2023, 12:45 PM

tomek accepted this revision.Nov 6 2023, 5:09 AM

This revision is now accepted and ready to land.Nov 6 2023, 5:09 AM

ashoat retitled this revision from [Flow202][lib] [21/23] Fix Flow issues with iterating through chars in a string to [Flow202][lib][skip-ci] [21/23] Fix Flow issues with iterating through chars in a string.Nov 19 2023, 4:55 PM

This revision was landed with ongoing or failed builds.Nov 27 2023, 3:25 PM

Closed by commit rCOMM94a0833ef487: [Flow202][lib][skip-ci] [21/23] Fix Flow issues with iterating through chars in… (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM94a0833ef487: [Flow202][lib][skip-ci] [21/23] Fix Flow issues with iterating through chars in….