Page MenuHomePhabricator

[Flow202][native][skip-ci] [37/x] Allow removeEditMode to take a TabAction
ClosedPublic

Authored by ashoat on Nov 27 2023, 1:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 7:17 AM
Unknown Object (File)
Mon, Oct 28, 8:20 AM
Unknown Object (File)
Thu, Oct 17, 11:50 AM
Unknown Object (File)
Thu, Oct 17, 11:50 AM
Unknown Object (File)
Thu, Oct 17, 11:49 AM
Unknown Object (File)
Thu, Oct 17, 11:49 AM
Unknown Object (File)
Sep 15 2024, 11:53 PM
Unknown Object (File)
Sep 15 2024, 3:21 PM
Subscribers
None

Details

Summary

We call removeEditMode in native/navigation/tab-router.js, so it needs to be able to support a TabAction as well as ChatRouterNavigationAction. Separating this diff out because the changes are non-obvious.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10020

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.
native/navigation/nav-selectors.js
45 ↗(On Diff #33666)

Snuck this change in. We still have some type-only imports that don't have the .js suffix

This revision is now accepted and ready to land.Nov 27 2023, 7:13 AM