[Flow202][landing][skip-ci] [1/2] Fix Flow issues in non-SIWE code
ClosedPublic
Actions

Authored by ashoat on Nov 5 2023, 7:19 AM.

Details

Reviewers

ginsu

Commits

rCOMM233dc1457444: [Flow202][landing][skip-ci] [1/2] Fix Flow issues in non-SIWE code

Summary

Separating out the SIWE code since I think different reviewers make sense.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Test Plan

Make sure all Flow issues in landing are resolved outside of SIWE code

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 5 2023, 7:19 AM

Herald added subscribers: will, tomek. · View Herald TranscriptNov 5 2023, 7:19 AM

ashoat added a child revision: D9720: [Flow202][landing][skip-ci] [2/2] Fix Flow issues in SIWE code.Nov 5 2023, 7:19 AM

ashoat edited the summary of this revision. (Show Details)Nov 5 2023, 7:20 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 5 2023, 7:29 AM

Harbormaster failed remote builds in B23761: Diff 32723!

ashoat requested review of this revision.Nov 5 2023, 7:51 AM

ashoat added inline comments.

landing/subscription-form.react.js
87–94 ↗	(On Diff #32723)	I `git grep`'d for `onChange=` in `web` and mirrored what we do there

ashoat retitled this revision from [Flow202][landing] [1/2] Fix Flow issues in non-SIWE code to [Flow202][landing] [0/1] Fix Flow issues in non-SIWE code.Nov 5 2023, 8:09 AM

ashoat retitled this revision from [Flow202][landing] [0/1] Fix Flow issues in non-SIWE code to [Flow202][landing] [1/2] Fix Flow issues in non-SIWE code.

ashoat edited the summary of this revision. (Show Details)Nov 5 2023, 8:12 AM

ashoat added a parent revision: D9715: [Flow202][lib][skip-ci] [23/23] Fix Flow issues in lib/utils/action-logger.js.

ginsu accepted this revision.Nov 6 2023, 7:43 PM

This revision is now accepted and ready to land.Nov 6 2023, 7:43 PM

ashoat edited parent revisions, added: D9749: [Flow202][lib][skip-ci] [25/23] Fix Flow issues from Kamil's recently landed diffs; removed: D9715: [Flow202][lib][skip-ci] [23/23] Fix Flow issues in lib/utils/action-logger.js.Nov 7 2023, 7:02 AM

ashoat edited parent revisions, added: D9751: [Flow202][lib][skip-ci] [26/23] Fix type error in DeviceTokenUpdateRequest; removed: D9749: [Flow202][lib][skip-ci] [25/23] Fix Flow issues from Kamil's recently landed diffs.Nov 7 2023, 10:43 AM

ashoat retitled this revision from [Flow202][landing] [1/2] Fix Flow issues in non-SIWE code to [Flow202][landing][skip-ci] [1/2] Fix Flow issues in non-SIWE code.Nov 19 2023, 4:59 PM

This revision was landed with ongoing or failed builds.Nov 27 2023, 3:25 PM

Closed by commit rCOMM233dc1457444: [Flow202][landing][skip-ci] [1/2] Fix Flow issues in non-SIWE code (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM233dc1457444: [Flow202][landing][skip-ci] [1/2] Fix Flow issues in non-SIWE code.