Differential D10045 Authored by ashoat on Nov 27 2023, 1:31 AM.
Details Summary There is only case now after D1971, so the Platform.select should be removed. NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.
Depends on D10044 Test Plan Confirm the Flow errors go away
Diff Detail
Event Timelineashoat created this revision. Harbormaster completed remote builds in B24487: Diff 33690.Nov 27 2023, 1:31 AM2023-11-27 01:31:59 (UTC-8) This revision is now accepted and ready to land.Nov 27 2023, 7:25 AM2023-11-27 07:25:52 (UTC-8) Closed by commit rCOMM8afb4e31c872: [Flow202][native][skip-ci] [61/x] Get rid of Platform.select in… (authored by ashoat). · Explain WhyNov 27 2023, 3:29 PM2023-11-27 15:29:34 (UTC-8) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 33928 |