Page MenuHomePhabricator
Differential D9859

[Flow202][keyserver][skip-ci] [10/x] Address type errors with promiseAll / Promise.all
ClosedPublic
Actions

Authored by ashoat on Nov 13 2023, 3:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 6, 4:47 PM
Unknown Object (File)
Sun, May 5, 12:58 AM
Unknown Object (File)
Wed, May 1, 11:15 PM
Unknown Object (File)
Wed, May 1, 11:15 PM
Unknown Object (File)
Apr 16 2024, 6:00 PM
Unknown Object (File)
Apr 16 2024, 5:59 PM
Unknown Object (File)
Apr 15 2024, 9:16 PM
Unknown Object (File)
Apr 15 2024, 9:16 PM
View All 58 Files
Subscribers
None

Details

Reviewers
tomek
Commits
rCOMMce2d360cd7e5: [Flow202][keyserver][skip-ci] [10/x] Address type errors with promiseAll /…
Summary

The new version of Flow is fairly particular about these. I had to restructure some of the log in places to use async IIFEs.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9858

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 13 2023, 3:10 PM
ashoat mentioned this in D9858: [Flow202][keyserver][skip-ci] [9/x] Fix Flow issues with types of variables that get mutated.Nov 13 2023, 3:14 PM
ashoat added a child revision: D9860: [Flow202][keyserver][skip-ci] [11/x] Address type errors with memberOfContainingThread.Nov 13 2023, 3:15 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 13 2023, 3:21 PM
Harbormaster failed remote builds in B24076: Diff 33175!
ashoat updated this revision to Diff 33193.Nov 13 2023, 6:31 PM

Some promise stuff that accidentally got into D9858

ashoat added inline comments.Nov 13 2023, 6:33 PM
keyserver/src/creators/update-creator.js
437–446 ↗(On Diff #33193)

Snuck this fix in

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 13 2023, 6:42 PM
Harbormaster failed remote builds in B24094: Diff 33193!
ashoat requested review of this revision.Nov 14 2023, 6:16 AM
tomek accepted this revision.Nov 14 2023, 8:34 AM
This revision is now accepted and ready to land.Nov 14 2023, 8:34 AM
ashoat retitled this revision from [Flow202][keyserver] [10/x] Address type errors with promiseAll / Promise.all to [Flow202][keyserver][skip-ci] [10/x] Address type errors with promiseAll / Promise.all.Nov 19 2023, 5:06 PM
ashoat updated this revision to Diff 33625.Nov 26 2023, 11:23 PM

Rebase

Harbormaster completed remote builds in B24422: Diff 33625.Nov 26 2023, 11:23 PM
ashoat updated this revision to Diff 33779.Nov 27 2023, 2:10 PM

Rebase

Harbormaster completed remote builds in B24547: Diff 33779.Nov 27 2023, 2:10 PM
Closed by commit rCOMMce2d360cd7e5: [Flow202][keyserver][skip-ci] [10/x] Address type errors with promiseAll /… (authored by ashoat). · Explain WhyNov 27 2023, 3:27 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMce2d360cd7e5: [Flow202][keyserver][skip-ci] [10/x] Address type errors with promiseAll /….
inka mentioned this in D10189: [keyserver] Fix error when changing thread description.Dec 5 2023, 2:28 AM
inka mentioned this in rCOMM608cc2e82423: [keyserver] Fix error when changing thread description.Dec 5 2023, 6:20 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
25 lines
17 lines
150 lines
deleters/
29 lines
fetchers/
2 lines
push/
26 lines
20 lines
responders/
5 lines
31 lines
session/
8 lines
socket/
21 lines
updaters/
22 lines
48 lines

Diff 33852

View Options

keyserver/src/creators/message-report-creator.js

Loading...
View Options

keyserver/src/creators/thread-creator.js

Loading...
View Options

keyserver/src/creators/update-creator.js

Loading...
View Options

keyserver/src/deleters/account-deleters.js

Loading...
View Options

keyserver/src/fetchers/thread-fetchers.js

Loading...
View Options

keyserver/src/push/rescind.js

Loading...
View Options

keyserver/src/push/send.js

Loading...
View Options

keyserver/src/responders/redux-state-responders.js

Loading...
View Options

keyserver/src/responders/user-responders.js

Loading...
View Options

keyserver/src/session/cookies.js

Loading...
View Options

keyserver/src/socket/socket.js

Loading...
View Options

keyserver/src/updaters/thread-permission-updaters.js

Loading...
View Options

keyserver/src/updaters/thread-updaters.js

Loading...