Page MenuHomePhabricator

[Flow202][keyserver][skip-ci] [10/x] Address type errors with promiseAll / Promise.all
ClosedPublic

Authored by ashoat on Nov 13 2023, 3:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 6, 4:47 PM
Unknown Object (File)
Sun, May 5, 12:58 AM
Unknown Object (File)
Wed, May 1, 11:15 PM
Unknown Object (File)
Wed, May 1, 11:15 PM
Unknown Object (File)
Tue, Apr 16, 6:00 PM
Unknown Object (File)
Tue, Apr 16, 5:59 PM
Unknown Object (File)
Mon, Apr 15, 9:16 PM
Unknown Object (File)
Mon, Apr 15, 9:16 PM
Subscribers
None

Details

Summary

The new version of Flow is fairly particular about these. I had to restructure some of the log in places to use async IIFEs.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9858

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 13 2023, 3:21 PM
Harbormaster failed remote builds in B24076: Diff 33175!

Some promise stuff that accidentally got into D9858

keyserver/src/creators/update-creator.js
437–446 ↗(On Diff #33193)

Snuck this fix in

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 13 2023, 6:42 PM
Harbormaster failed remote builds in B24094: Diff 33193!
This revision is now accepted and ready to land.Nov 14 2023, 8:34 AM
ashoat retitled this revision from [Flow202][keyserver] [10/x] Address type errors with promiseAll / Promise.all to [Flow202][keyserver][skip-ci] [10/x] Address type errors with promiseAll / Promise.all.Nov 19 2023, 5:06 PM