Differential D9720 Authored by ashoat on Nov 5 2023, 7:19 AM.
Details Summary Separating out the SIWE code since I think different reviewers make sense. NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.
Depends on D9719 Test Plan Make sure all Flow errors in landing are resolved
Diff Detail
Event TimelineHerald added subscribers: will, tomek. · View Herald TranscriptNov 5 2023, 7:19 AM2023-11-05 07:19:59 (UTC-8) Harbormaster returned this revision to the author for changes because remote builds failed.Nov 5 2023, 7:30 AM2023-11-05 07:30:55 (UTC-8) ashoat retitled this revision from [Flow202][landing] [2/2] Fix Flow issues in SIWE code to [Flow202][landing] [1/1] Fix Flow issues in SIWE code.Nov 5 2023, 8:09 AM2023-11-05 08:09:51 (UTC-8) ashoat retitled this revision from [Flow202][landing] [1/1] Fix Flow issues in SIWE code to [Flow202][landing] [2/2] Fix Flow issues in SIWE code. This revision is now accepted and ready to land.Nov 5 2023, 11:34 AM2023-11-05 11:34:51 (UTC-8) Harbormaster failed remote builds in B23862: Diff 32890!Nov 7 2023, 7:04 AM2023-11-07 07:04:11 (UTC-8) ashoat retitled this revision from [Flow202][landing] [2/2] Fix Flow issues in SIWE code to [Flow202][landing][skip-ci] [2/2] Fix Flow issues in SIWE code.Nov 19 2023, 5:00 PM2023-11-19 17:00:07 (UTC-8) This revision was landed with ongoing or failed builds.Nov 27 2023, 3:25 PM2023-11-27 15:25:57 (UTC-8) Closed by commit rCOMMeb44f8bcdb14: [Flow202][landing][skip-ci] [2/2] Fix Flow issues in SIWE code (authored by ashoat). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 33819 |