objects.js
ClosedPublic
Actions

Authored by ashoat on Nov 4 2023, 12:06 PM.

Details

Reviewers

atul

Commits

rCOMMe05be194c927: [Flow202][lib][skip-ci] [20/23] Get rid of $FlowFixMes in lib/utils/objects.js

Summary

The types of Object.values and Object.keys are fixed in the new version of Flow, so we don't need these $FlowFixMes anymore.

I made two other small changes:

Fixed a Flow error due to the return type of assertObjectsAreEqual not being typed.
Got rid of the keys utility, which was just an alias to Object.keys and was causing some sort of type error.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9711

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 4 2023, 12:06 PM

Herald added subscribers: will, tomek. · View Herald TranscriptNov 4 2023, 12:06 PM

ashoat added a child revision: D9713: [Flow202][lib][skip-ci] [21/23] Fix Flow issues with iterating through chars in a string.Nov 4 2023, 12:07 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 4 2023, 12:38 PM

Harbormaster failed remote builds in B23754: Diff 32716!

ashoat requested review of this revision.Nov 4 2023, 12:45 PM

atul accepted this revision.Nov 5 2023, 11:33 AM

This revision is now accepted and ready to land.Nov 5 2023, 11:33 AM

ashoat retitled this revision from [Flow202][lib] [20/23] Get rid of $FlowFixMes in lib/utils/objects.js to [Flow202][lib][skip-ci] [20/23] Get rid of $FlowFixMes in lib/utils/objects.js.Nov 19 2023, 4:54 PM

This revision was landed with ongoing or failed builds.Nov 27 2023, 3:25 PM

Closed by commit rCOMMe05be194c927: [Flow202][lib][skip-ci] [20/23] Get rid of $FlowFixMes in lib/utils/objects.js (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMe05be194c927: [Flow202][lib][skip-ci] [20/23] Get rid of $FlowFixMes in lib/utils/objects.js.