[Flow202][keyserver][skip-ci] [3/x] Address type errors in validateCandidateMembers
ClosedPublic
Actions

Authored by ashoat on Nov 13 2023, 2:44 PM.

Details

Reviewers

tomek

Commits

rCOMM271c0ab13ab4: [Flow202][keyserver][skip-ci] [3/x] Address type errors in…

Summary

Separating this out into its own diff because I made some more opinionated changes here.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9850

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 13 2023, 2:44 PM

ashoat added a child revision: D9852: [Flow202][keyserver][skip-ci] [4/x] Address type error in rescindPushNotifs.Nov 13 2023, 2:47 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 13 2023, 2:55 PM

Harbormaster failed remote builds in B24067: Diff 33165!

ashoat requested review of this revision.Nov 14 2023, 6:14 AM

ashoat added inline comments.

keyserver/src/fetchers/thread-permission-fetchers.js
203 ↗	(On Diff #33165)	We have only two callsites of `validateCandidateMembers` and neither of them need this line. Always better to use exact objects when possible
352 ↗	(On Diff #33165)	This change let me type as `$ReadOnlyArray<string>` instead of `Array<string>`, with no negative performance impacts

tomek accepted this revision.Nov 14 2023, 7:34 AM

This revision is now accepted and ready to land.Nov 14 2023, 7:34 AM

ashoat retitled this revision from [Flow202][keyserver] [3/x] Address type errors in validateCandidateMembers to [Flow202][keyserver][skip-ci] [3/x] Address type errors in validateCandidateMembers.Nov 19 2023, 5:05 PM

This revision was landed with ongoing or failed builds.Nov 27 2023, 3:26 PM

Closed by commit rCOMM271c0ab13ab4: [Flow202][keyserver][skip-ci] [3/x] Address type errors in… (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM271c0ab13ab4: [Flow202][keyserver][skip-ci] [3/x] Address type errors in….