Page MenuHomePhabricator

[Flow202][native][skip-ci] [19/x] Remove unused guardedSetState function in DeleteThread
ClosedPublic

Authored by ashoat on Nov 27 2023, 12:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 6:00 AM
Unknown Object (File)
Sun, Dec 22, 6:00 AM
Unknown Object (File)
Sun, Dec 22, 6:00 AM
Unknown Object (File)
Sun, Dec 22, 6:00 AM
Unknown Object (File)
Fri, Dec 13, 10:29 PM
Unknown Object (File)
Fri, Nov 29, 3:30 PM
Unknown Object (File)
Fri, Nov 29, 2:06 PM
Unknown Object (File)
Nov 26 2024, 9:32 PM
Subscribers

Details

Summary

We removed the last usage in D6103, but didn't remove the function itself. The new version of Flow wanted me to add typehints, but instead I'm just going to delete the function since it's not used.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10002

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable