Page MenuHomePhabricator

[Flow202][native][skip-ci] [3/x] Introduce @react-navigation/core libdef
ClosedPublic

Authored by ashoat on Nov 27 2023, 12:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 5:03 AM
Unknown Object (File)
Thu, Nov 7, 3:50 PM
Unknown Object (File)
Sat, Nov 2, 9:00 AM
Unknown Object (File)
Sun, Oct 27, 5:51 PM
Unknown Object (File)
Oct 22 2024, 4:44 PM
Unknown Object (File)
Oct 20 2024, 6:35 PM
Unknown Object (File)
Oct 4 2024, 12:13 PM
Unknown Object (File)
Sep 30 2024, 6:40 PM
Subscribers
None

Details

Summary

I need this in the following diff, but I make some changes to it there. To make those changes more clear, I'm separating the introduction of this new libdef into its own diff.

I generated this with the following steps:

  1. cd native
  2. flow-typed install @react-navigation/core@5: Installs the latest version of the libdef I had introduced on flow-typed, but I haven't kept that updated unfortunately. Since I've updated the local versions of the other libdefs since then, step 4 was needed.
  3. mv flow-typed/npm/@react-navigation/core_v5.x.x.js flow-typed/npm/@react-navigation/core_v6.x.x.js: The version of the libdefs I have on flow-typed is for ReactNav 5. There have since been some changes, which I updated in the local libdefs.
  4. Open up the new libdef and copy in "SECTION 1" (the part that is mirrored across all of the libdefs) from another one of the libdefs (I used the one for @react-navigation/native, but they should all be identical).
NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9986

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable