Page MenuHomePhabricator

[Flow202][native][skip-ci] [36/x] Type Redux state when it includes navState from dev tools
ClosedPublic

Authored by ashoat on Nov 27 2023, 1:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 5 2024, 7:43 AM
Unknown Object (File)
Mar 5 2024, 7:43 AM
Unknown Object (File)
Mar 5 2024, 7:43 AM
Unknown Object (File)
Mar 5 2024, 7:42 AM
Unknown Object (File)
Feb 10 2024, 4:13 AM
Unknown Object (File)
Dec 19 2023, 4:41 PM
Unknown Object (File)
Dec 16 2023, 10:02 AM
Unknown Object (File)
Dec 16 2023, 8:07 AM
Subscribers

Details

Summary

We have a unique integration with redux-devtools that shows updates to ReactNav state and Redux state simultaneously. This diff introduces the type MonitorActionState for this combined state.

In addition, we have some custom code to support the dev tools user attempting to revert the state to a particular point. In those scenarios, navState actually gets inserted into the Redux state, and NavFromReduxHandler is responsible for extracting the nav state from the Redux state and putting it into ReactNav. This diff fixes up the types for NavFromReduxHandler as well.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10019

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable