Page MenuHomePhabricator

[Flow202][lib][skip-ci] [5/23] Fix Flow issues with missing annotations on parameters in function declarations
ClosedPublic

Authored by ashoat on Nov 4 2023, 11:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 10, 12:40 AM
Unknown Object (File)
Sun, May 5, 5:46 AM
Unknown Object (File)
Thu, May 2, 10:09 PM
Unknown Object (File)
Wed, May 1, 6:55 PM
Unknown Object (File)
Tue, Apr 30, 6:35 PM
Unknown Object (File)
Sun, Apr 28, 3:58 PM
Unknown Object (File)
Fri, Apr 26, 2:56 PM
Unknown Object (File)
Thu, Apr 25, 2:20 PM
Subscribers

Details

Summary

The new version of Flow is showing a bunch of errors that look like this:

Error -------------------------------------------------------------------------- components/modal-overlay.react.js:35:51

An annotation on event is required because Flow cannot infer its type from local context. [missing-local-annot]

     32|     }
     33|   }, []);
     34|
     35|   const onBackgroundMouseDown = React.useCallback(event => {
     36|     firstClickRef.current = event.target;
     37|   }, []);
     38|

This diff adds the required annotations.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9696

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 4 2023, 12:12 PM
Harbormaster failed remote builds in B23739: Diff 32701!
This revision is now accepted and ready to land.Nov 6 2023, 4:39 AM
ashoat retitled this revision from [Flow202][lib] [5/23] Fix Flow issues with missing annotations on parameters in function declarations to [Flow202][lib][skip-ci] [5/23] Fix Flow issues with missing annotations on parameters in function declarations.Nov 19 2023, 11:46 AM