HomePhabricator
Diffusion Comm 8cbe88a6c29d

[Flow202][web][skip-ci] [5/x] Address missing-local-annot type errors

Description

[Flow202][web][skip-ci] [5/x] Address missing-local-annot type errors

Summary:
The new version of Flow wants more annotations for function and member definitions. This diff adds all of the required annotations to the web codebase necessary to clear all missing-local-annot errors. The lib equivalent of this diff is D9697.

I also included some other changes where I type function params that were yielding other Flow errors (different from missing-local-annot).

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9770

Test Plan: Confirm the Flow errors go away

Reviewers: tomek

Reviewed By: tomek

Subscribers: wyilio

Differential Revision: https://phab.comm.dev/D9771

Details

Provenance
ashoatAuthored on Nov 7 2023, 6:00 PM
Reviewer
tomek
Differential Revision
D9771: [Flow202][web][skip-ci] [5/x] Address missing-local-annot type errors
Parents
rCOMM6e069d385b82: [Flow202][web][skip-ci] [4/x] Extract definition of…
Branches
Unknown
Tags
Unknown