[Flow202][keyserver][skip-ci] [17/x] Fix type parameterization of accountUpdateInputValidator
ClosedPublic
Actions

Authored by ashoat on Nov 13 2023, 3:21 PM.

Details

Reviewers

michal

Commits

rCOMMf1140ba9615f: [Flow202][keyserver][skip-ci] [17/x] Fix type parameterization of…

Summary

The Flow type doesn't mention the deprecated email field. Since this is listed in the input validator, we need to introduce a new matching Flow type.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9865

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 13 2023, 3:21 PM

Herald added a subscriber: tomek. · View Herald TranscriptNov 13 2023, 3:21 PM

ashoat added a child revision: D9867: [Flow202][keyserver][skip-ci] [18/x] Fix Flow issues with baseGetENSNames.bind.Nov 13 2023, 3:22 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 13 2023, 3:33 PM

Harbormaster failed remote builds in B24083: Diff 33182!

ashoat requested review of this revision.Nov 14 2023, 6:18 AM

As an alternative, in a few places where I had to deal with a deprecated field I typed them as an optional empty field (e.g. email?: empty):

we don't need to introduce a new type
flow still guards us against using the deprecated field on the server

This revision is now accepted and ready to land.Nov 14 2023, 7:34 AM

@michal's suggestion

Harbormaster failed remote builds in B24117: Diff 33217!Nov 14 2023, 10:26 AM

ashoat retitled this revision from [Flow202][keyserver] [17/x] Fix type parameterization of accountUpdateInputValidator to [Flow202][keyserver][skip-ci] [17/x] Fix type parameterization of accountUpdateInputValidator.Nov 19 2023, 5:08 PM

This revision was landed with ongoing or failed builds.Nov 27 2023, 3:27 PM

Closed by commit rCOMMf1140ba9615f: [Flow202][keyserver][skip-ci] [17/x] Fix type parameterization of… (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMf1140ba9615f: [Flow202][keyserver][skip-ci] [17/x] Fix type parameterization of….