Differential D9991 Authored by ashoat on Nov 27 2023, 12:29 AM.
Details Summary This was accidentally left over in D9171. The new version of Flow picked up the issue. NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.
Depends on D9990 Test Plan Confirm the Flow errors go away
Diff Detail
Event TimelineHerald added a subscriber: tomek. · View Herald TranscriptNov 27 2023, 12:29 AM2023-11-27 00:29:59 (UTC-8) Harbormaster completed remote builds in B24432: Diff 33635.Nov 27 2023, 12:30 AM2023-11-27 00:30:02 (UTC-8) This revision is now accepted and ready to land.Nov 27 2023, 9:35 AM2023-11-27 09:35:00 (UTC-8) Closed by commit rCOMM7623096b8bd2: [Flow202][native][skip-ci] [7/x] Fix leftover this keyword in ChatThreadList… (authored by ashoat). · Explain WhyNov 27 2023, 3:27 PM2023-11-27 15:27:45 (UTC-8) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 33874 |