[native] Lift `onPressItem` and `onPressSeeMoreSidebars` to `ConnectedChatThreadList`
ClosedPublic
Actions

Authored by atul on Tue, Sep 12, 3:59 PM.

Details

Reviewers

ginsu
rohan
tomek

Commits

rCOMMd6827690bc41: [native] Lift `onPressItem` and `onPressSeeMoreSidebars` to…

Summary

This diff is just one step in the process of converting ChatThreadList into a functional component. When this work is done, we will be able to avoid a lot of re-rendering and hopefully improve performance quite a bit.

Depends on D9166

Test Plan

ChatThreadList + search experience continue to work as expected.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Tue, Sep 12, 3:59 PM

Herald added a subscriber: ashoat. · View Herald TranscriptTue, Sep 12, 3:59 PM

atul published this revision for review.Tue, Sep 12, 3:59 PM

stage all

Harbormaster completed remote builds in B22565: Diff 31015.Tue, Sep 12, 4:16 PM

Harbormaster completed remote builds in B22566: Diff 31016.Tue, Sep 12, 4:20 PM

atul added a child revision: D9172: [native] Lift `hardwareBack` to `ConnectedChatThreadList`.Tue, Sep 12, 4:51 PM

ginsu accepted this revision.Wed, Sep 13, 9:36 AM

This revision is now accepted and ready to land.Wed, Sep 13, 9:36 AM

Closed by commit rCOMMd6827690bc41: [native] Lift `onPressItem` and `onPressSeeMoreSidebars` to… (authored by atul). · Explain WhyWed, Sep 13, 11:30 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMd6827690bc41: [native] Lift `onPressItem` and `onPressSeeMoreSidebars` to….

Revision Contents
Changeset List

Path

Size

native/

chat/

chat-thread-list.react.js

64 lines

Diff 31088

View Options

native/chat/chat-thread-list.react.js

[native] Lift `onPressItem` and `onPressSeeMoreSidebars` to `ConnectedChatThreadList`ClosedPublicActions