This diff is just one step in the process of converting ChatThreadList into a functional component. When this work is done, we will be able to avoid a lot of re-rendering and hopefully improve performance quite a bit.
Depends on D9173
Details
Details
ChatThreadList + search experience continue to work as expected.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
One concern inline
| native/chat/chat-thread-list.react.js | ||
|---|---|---|
| 587 ↗ | (On Diff #31019) | Should this be read only? |
| native/chat/chat-thread-list.react.js | ||
|---|---|---|
| 587 ↗ | (On Diff #31019) | That's how they were typed previously, can try making them $ReadOnly |
| native/chat/chat-thread-list.react.js | ||
|---|---|---|
| 587 ↗ | (On Diff #31019) | JK, you're totally right. The chatItems "inside" should be Item[] since we're pushing and unshifting, but both listData and partialListData should be $ReadOnlyArray<Item> |