Page MenuHomePhabricator

[native] Lift `search[Status/Text]` state to `ConnectedChatThreadList`
ClosedPublic

Authored by atul on Sep 11 2023, 1:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 11, 7:53 PM
Unknown Object (File)
Mon, Jun 3, 6:33 PM
Unknown Object (File)
Mon, Jun 3, 6:33 PM
Unknown Object (File)
Mon, Jun 3, 6:33 PM
Unknown Object (File)
Mon, Jun 3, 6:20 PM
Unknown Object (File)
Thu, May 30, 1:59 AM
Unknown Object (File)
Apr 29 2024, 8:01 AM
Unknown Object (File)
Apr 26 2024, 4:57 PM
Subscribers

Details

Summary

(I initially had a huge diff that converted ChatThreadList to a functional component and added various memoizations. However, I realized that diff would be pretty difficult to review so I'm breaking down the refactor into hopefully easier to review pieces.)

This diff is just one step in the process of converting ChatThreadList into a functional component. When this work is done, we will be able to avoid a lot of re-rendering and hopefully improve performance quite a bit.

Test Plan

Search experience continued to work as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul requested review of this revision.Sep 11 2023, 1:36 PM
This revision is now accepted and ready to land.Sep 11 2023, 3:59 PM

Thanks for breaking down this diff! It is super clear what the changes are!!

This revision was landed with ongoing or failed builds.Sep 12 2023, 12:19 PM
This revision was automatically updated to reflect the committed changes.