Page MenuHomePhabricator
Differential D9184

[native] Lift `FlatList` to `ConnectedChatThreadList`
ClosedPublic
Actions

Authored by atul on Sep 13 2023, 9:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 11, 6:24 PM
Unknown Object (File)
Wed, Sep 11, 6:24 PM
Unknown Object (File)
Wed, Sep 11, 6:24 PM
Unknown Object (File)
Wed, Sep 11, 6:23 PM
Unknown Object (File)
Wed, Sep 11, 6:17 PM
Unknown Object (File)
Sun, Aug 25, 1:07 PM
Unknown Object (File)
Sun, Aug 25, 5:52 AM
Unknown Object (File)
Aug 17 2024, 11:09 PM
View All 57 Files
Subscribers
ashoat

Details

Reviewers
ginsu
tomek
rohan
Commits
rCOMM5edb5901e5de: [native] Lift `FlatList` to `ConnectedChatThreadList`
Summary

This diff is just one step in the process of converting ChatThreadList into a functional component. When this work is done, we will be able to avoid a lot of re-rendering and hopefully improve performance quite a bit.

This should be the second to last diff in converting ChatThreadList to a functional component. After that I'll do some cleanup/refactoring to make the component more readable (group hooks, break search into its own component, etc).

Depends on D9183

Test Plan

ChatThreadList + search experience continue to work as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Sep 13 2023, 9:53 AM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 13 2023, 9:53 AM
atul published this revision for review.Sep 13 2023, 9:58 AM
atul updated this revision to Diff 31072.Sep 13 2023, 10:00 AM

resolve merge conflicts

atul added a child revision: D9188: [native] Lift `onTabPress` to `ConnectedChatThreadList`.Sep 13 2023, 10:09 AM
Harbormaster completed remote builds in B22598: Diff 31068.Sep 13 2023, 10:09 AM
Harbormaster completed remote builds in B22602: Diff 31072.Sep 13 2023, 10:22 AM
ginsu accepted this revision.Sep 13 2023, 1:23 PM

One question inline

native/chat/chat-thread-list.react.js
236–238 ↗(On Diff #31072)

Should this be deleted?

This revision is now accepted and ready to land.Sep 13 2023, 1:23 PM
atul added inline comments.Sep 13 2023, 2:52 PM
native/chat/chat-thread-list.react.js
236–238 ↗(On Diff #31072)

It gets deleted in subsequent diff

Closed by commit rCOMM5edb5901e5de: [native] Lift `FlatList` to `ConnectedChatThreadList` (authored by atul). · Explain WhySep 13 2023, 2:56 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM5edb5901e5de: [native] Lift `FlatList` to `ConnectedChatThreadList`.

Revision Contents
Changeset List

PathSize
native/
chat/
122 lines

Diff 31102

View Options

native/chat/chat-thread-list.react.js

Loading...