Page MenuHomePhabricator

[native] Lift `FlatList` to `ConnectedChatThreadList`
ClosedPublic

Authored by atul on Wed, Sep 13, 9:53 AM.

Details

Summary

This diff is just one step in the process of converting ChatThreadList into a functional component. When this work is done, we will be able to avoid a lot of re-rendering and hopefully improve performance quite a bit.

This should be the second to last diff in converting ChatThreadList to a functional component. After that I'll do some cleanup/refactoring to make the component more readable (group hooks, break search into its own component, etc).


Depends on D9183

Test Plan

ChatThreadList + search experience continue to work as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Wed, Sep 13, 9:58 AM

One question inline

native/chat/chat-thread-list.react.js
236–238 ↗(On Diff #31072)

Should this be deleted?

This revision is now accepted and ready to land.Wed, Sep 13, 1:23 PM
native/chat/chat-thread-list.react.js
236–238 ↗(On Diff #31072)

It gets deleted in subsequent diff