Page MenuHomePhabricator
Differential D9161

[native] Lift `onScroll` to `ConnectedChatThreadList`
ClosedPublic
Actions

Authored by atul on Sep 12 2023, 1:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 16, 6:33 AM
Unknown Object (File)
Wed, Jul 10, 1:29 AM
Unknown Object (File)
Tue, Jul 9, 11:16 AM
Unknown Object (File)
Mon, Jul 8, 10:39 PM
Unknown Object (File)
Sat, Jun 29, 8:34 PM
Unknown Object (File)
Sat, Jun 29, 6:36 AM
Unknown Object (File)
Thu, Jun 27, 2:49 PM
Unknown Object (File)
Thu, Jun 27, 2:39 PM
View All 54 Files
Subscribers
ashoat

Details

Reviewers
ginsu
tomek
rohan
Commits
rCOMM3a4e9c686ee5: [native] Lift `onScroll` to `ConnectedChatThreadList`
Summary

This diff is just one step in the process of converting ChatThreadList into a functional component. When this work is done, we will be able to avoid a lot of re-rendering and hopefully improve performance quite a bit.

Depends on D9136

Test Plan

ChatThreadList + search experience continue to work as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Sep 12 2023, 1:57 PM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 12 2023, 1:57 PM
atul added a child revision: D9164: [native] Lift `onSwipeableWillOpen` and `composeThread` to `ConnectedChatThreadList`.Sep 12 2023, 2:06 PM
atul published this revision for review.Sep 12 2023, 2:07 PM
Harbormaster completed remote builds in B22549: Diff 30995.Sep 12 2023, 2:22 PM
ginsu accepted this revision.Sep 12 2023, 9:37 PM

please see inline comment before landing

native/chat/chat-thread-list.react.js
129 ↗(On Diff #30995)

I think this should be mixed

This revision is now accepted and ready to land.Sep 12 2023, 9:37 PM
atul added inline comments.Sep 13 2023, 7:36 AM
native/chat/chat-thread-list.react.js
129 ↗(On Diff #30995)

That's fair.

In a couple diffs though I completely remove these props after merging everything into a single component, so I think it's fine to leave as-is for now since this is temporary?

Closed by commit rCOMM3a4e9c686ee5: [native] Lift `onScroll` to `ConnectedChatThreadList` (authored by atul). · Explain WhySep 13 2023, 8:23 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM3a4e9c686ee5: [native] Lift `onScroll` to `ConnectedChatThreadList`.

Revision Contents
Changeset List

PathSize
native/
chat/
29 lines

Diff 31053

View Options

native/chat/chat-thread-list.react.js

Loading...