Page MenuHomePhabricator

[native] Lift `onScroll` to `ConnectedChatThreadList`
ClosedPublic

Authored by atul on Sep 12 2023, 1:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 5, 2:11 AM
Unknown Object (File)
Wed, May 1, 3:10 PM
Unknown Object (File)
Tue, Apr 30, 8:01 AM
Unknown Object (File)
Sun, Apr 28, 2:55 AM
Unknown Object (File)
Apr 16 2024, 6:00 PM
Unknown Object (File)
Apr 16 2024, 2:54 AM
Unknown Object (File)
Apr 15 2024, 8:46 PM
Unknown Object (File)
Apr 15 2024, 12:11 AM
Subscribers

Details

Summary

This diff is just one step in the process of converting ChatThreadList into a functional component. When this work is done, we will be able to avoid a lot of re-rendering and hopefully improve performance quite a bit.


Depends on D9136

Test Plan

ChatThreadList + search experience continue to work as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Sep 12 2023, 2:07 PM

please see inline comment before landing

native/chat/chat-thread-list.react.js
129 ↗(On Diff #30995)

I think this should be mixed

This revision is now accepted and ready to land.Sep 12 2023, 9:37 PM
native/chat/chat-thread-list.react.js
129 ↗(On Diff #30995)

That's fair.

In a couple diffs though I completely remove these props after merging everything into a single component, so I think it's fine to leave as-is for now since this is temporary?