[native] Lift `onTabPress` to `ConnectedChatThreadList`
ClosedPublic
Actions

Authored by atul on Sep 13 2023, 10:09 AM.

Details

Reviewers

ginsu
tomek
rohan

Commits

rCOMM0603be647052: [native] Lift `onTabPress` to `ConnectedChatThreadList`

Summary

This diff is just one step in the process of converting ChatThreadList into a functional component. When this work is done, we will be able to avoid a lot of re-rendering and hopefully improve performance quite a bit.

Depends on D9184

Test Plan

ChatThreadList + search experience continue to work as expected.

NOTE: Specifically tried tapping the tab and ensuring the scrollToTop functionality worked as expected.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Sep 13 2023, 10:09 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 13 2023, 10:09 AM

atul published this revision for review.Sep 13 2023, 10:09 AM

atul added a child revision: D9189: [native] Lift `component[DidMount/WillUnmount]` lifecycle methods to `useEffect` in `ConnectedChatThreadList`.Sep 13 2023, 10:28 AM

Harbormaster completed remote builds in B22606: Diff 31077.Sep 13 2023, 10:33 AM

ginsu accepted this revision.Sep 13 2023, 1:25 PM

This revision is now accepted and ready to land.Sep 13 2023, 1:25 PM

Closed by commit rCOMM0603be647052: [native] Lift `onTabPress` to `ConnectedChatThreadList` (authored by atul). · Explain WhySep 13 2023, 2:56 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM0603be647052: [native] Lift `onTabPress` to `ConnectedChatThreadList`.

Revision Contents
Changeset List

Path

Size

native/

chat/

chat-thread-list.react.js

28 lines

Diff 31104

View Options

native/chat/chat-thread-list.react.js

[native] Lift `onTabPress` to `ConnectedChatThreadList`ClosedPublicActions