Page MenuHomePhabricator

[native] Lift `onSwipeableWillOpen` and `composeThread` to `ConnectedChatThreadList`
ClosedPublic

Authored by atul on Sep 12 2023, 2:06 PM.
Tags
None
Referenced Files
F2087856: D9164.id31048.diff
Sun, Jun 23, 3:56 PM
Unknown Object (File)
Fri, Jun 21, 12:04 PM
Unknown Object (File)
Wed, Jun 19, 7:40 PM
Unknown Object (File)
Sat, Jun 15, 5:39 AM
Unknown Object (File)
Tue, Jun 11, 10:49 AM
Unknown Object (File)
Mon, May 27, 12:18 AM
Unknown Object (File)
Mon, May 27, 12:18 AM
Unknown Object (File)
Mon, May 27, 12:18 AM
Subscribers

Details

Summary

This diff is just one step in the process of converting ChatThreadList into a functional component. When this work is done, we will be able to avoid a lot of re-rendering and hopefully improve performance quite a bit.


Depends on D9161

Test Plan

ChatThreadList + search experience continue to work as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Sep 12 2023, 2:07 PM

please see inline comments before landing

native/chat/chat-thread-list.react.js
130 ↗(On Diff #31001)

mixed

131 ↗(On Diff #31001)

mixed

This revision is now accepted and ready to land.Sep 12 2023, 9:39 PM
native/chat/chat-thread-list.react.js
130 ↗(On Diff #31001)

That's fair.

In a couple diffs though I completely remove these props after merging everything into a single component, so I think it's fine to leave as-is for now since this is temporary?

This revision was landed with ongoing or failed builds.Sep 13 2023, 8:23 AM
This revision was automatically updated to reflect the committed changes.