Page MenuHomePhabricator
Differential D9164

[native] Lift `onSwipeableWillOpen` and `composeThread` to `ConnectedChatThreadList`
ClosedPublic
Actions

Authored by atul on Sep 12 2023, 2:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 10, 8:03 PM
Unknown Object (File)
Wed, Jul 10, 1:06 PM
Unknown Object (File)
Wed, Jul 10, 12:33 PM
Unknown Object (File)
Sat, Jul 6, 3:03 PM
Unknown Object (File)
Sat, Jun 29, 7:05 PM
Unknown Object (File)
Sat, Jun 29, 1:10 AM
Unknown Object (File)
Fri, Jun 28, 8:57 PM
Unknown Object (File)
Thu, Jun 27, 10:54 PM
View All 63 Files
Subscribers
ashoat

Details

Reviewers
ginsu
tomek
rohan
Commits
rCOMM5facba63469a: [native] Lift `onSwipeableWillOpen` and `composeThread` to…
Summary

This diff is just one step in the process of converting ChatThreadList into a functional component. When this work is done, we will be able to avoid a lot of re-rendering and hopefully improve performance quite a bit.

Depends on D9161

Test Plan

ChatThreadList + search experience continue to work as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Sep 12 2023, 2:06 PM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 12 2023, 2:06 PM
atul published this revision for review.Sep 12 2023, 2:07 PM
Harbormaster completed remote builds in B22554: Diff 31001.Sep 12 2023, 2:30 PM
atul added a child revision: D9166: [native] Lift `renderSearch` to `ConnectedChatThreadList`.Sep 12 2023, 3:06 PM
ginsu accepted this revision.Sep 12 2023, 9:39 PM

please see inline comments before landing

native/chat/chat-thread-list.react.js
130 ↗(On Diff #31001)

mixed

131 ↗(On Diff #31001)

mixed

This revision is now accepted and ready to land.Sep 12 2023, 9:39 PM
atul added inline comments.Sep 13 2023, 7:36 AM
native/chat/chat-thread-list.react.js
130 ↗(On Diff #31001)

That's fair.

In a couple diffs though I completely remove these props after merging everything into a single component, so I think it's fine to leave as-is for now since this is temporary?

atul updated this revision to Diff 31048.Sep 13 2023, 8:16 AM

rebase and land

This revision was landed with ongoing or failed builds.Sep 13 2023, 8:23 AM
Closed by commit rCOMM5facba63469a: [native] Lift `onSwipeableWillOpen` and `composeThread` to… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM5facba63469a: [native] Lift `onSwipeableWillOpen` and `composeThread` to….
Harbormaster completed remote builds in B22589: Diff 31048.Sep 13 2023, 8:34 AM

Revision Contents
Changeset List

PathSize
native/
chat/
42 lines

Diff 31054

View Options

native/chat/chat-thread-list.react.js

Loading...