Paths

Table of Contentst

-
native/chat/
-
chat/
1/1
chat-thread-list.react.js

[native] Lift `onSwipeableWillOpen` and `composeThread` to `ConnectedChatThreadList`
ClosedPublic
Actions

Authored by atul on Sep 12 2023, 2:06 PM.

Details

Reviewers

ginsu
tomek
rohan

Commits

rCOMM5facba63469a: [native] Lift `onSwipeableWillOpen` and `composeThread` to…

Summary

This diff is just one step in the process of converting ChatThreadList into a functional component. When this work is done, we will be able to avoid a lot of re-rendering and hopefully improve performance quite a bit.

Depends on D9161

Test Plan

ChatThreadList + search experience continue to work as expected.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Sep 12 2023, 2:06 PM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 12 2023, 2:06 PM

atul published this revision for review.Sep 12 2023, 2:07 PM

Harbormaster completed remote builds in B22554: Diff 31001.Sep 12 2023, 2:30 PM

atul added a child revision: D9166: [native] Lift `renderSearch` to `ConnectedChatThreadList`.Sep 12 2023, 3:06 PM

please see inline comments before landing

native/chat/chat-thread-list.react.js
130	`mixed`
131	`mixed`

This revision is now accepted and ready to land.Sep 12 2023, 9:39 PM

atul added inline comments.Sep 13 2023, 7:36 AM

native/chat/chat-thread-list.react.js
130	That's fair. In a couple diffs though I completely remove these props after merging everything into a single component, so I think it's fine to leave as-is for now since this is temporary?

rebase and land

This revision was landed with ongoing or failed builds.Sep 13 2023, 8:23 AM

Closed by commit rCOMM5facba63469a: [native] Lift `onSwipeableWillOpen` and `composeThread` to… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM5facba63469a: [native] Lift `onSwipeableWillOpen` and `composeThread` to….

Harbormaster completed remote builds in B22589: Diff 31048.Sep 13 2023, 8:34 AM

Revision Contents
Changeset List

Path

Size

native/

chat/

chat-thread-list.react.js

42 lines

Diff 31001

View Options

native/chat/chat-thread-list.react.js

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
	const styles = StyleSheet.create({			const styles = StyleSheet.create({
	dummyMessage: {			dummyMessage: {
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 6,
	},			},
	message: {			message: {
	overflow: 'hidden',			overflow: 'hidden',
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 8,
	},			},
	text: {			text: {
	fontFamily: 'Arial',			fontFamily: 'Arial',
	fontSize: 18,			fontSize: 14,
				benschacAuthorUnsubmitted Done Inline Actions I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better. benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
				lineHeight: 22,
	},			},
	});			});

	export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };			export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };

[native] Lift `onSwipeableWillOpen` and `composeThread` to `ConnectedChatThreadList`ClosedPublicActions