Page MenuHomePhabricator

[native] Lift `floatingAction` to `ConnectedChatThreadList`
ClosedPublic

Authored by atul on Sep 13 2023, 9:29 AM.
Tags
None
Referenced Files
F2089092: D9183.diff
Sun, Jun 23, 7:10 PM
Unknown Object (File)
Tue, Jun 18, 8:21 AM
Unknown Object (File)
Fri, Jun 14, 12:04 AM
Unknown Object (File)
Wed, Jun 12, 10:40 AM
Unknown Object (File)
Tue, Jun 11, 10:18 PM
Unknown Object (File)
Tue, May 28, 5:14 AM
Unknown Object (File)
Mon, May 27, 12:18 AM
Unknown Object (File)
Mon, May 27, 12:18 AM
Subscribers

Details

Summary

This diff is just one step in the process of converting ChatThreadList into a functional component. When this work is done, we will be able to avoid a lot of re-rendering and hopefully improve performance quite a bit.

NOTE: Also snuck in some cleanup to make diff where we merge into single component a bit more readable.

Depends on D9174

Test Plan

ChatThreadList + search experience continue to work as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Sep 13 2023, 9:37 AM

resolve merge conflicts and rebase

ginsu added inline comments.
native/chat/chat-thread-list.react.js
551 ↗(On Diff #31071)

Nit: Would personally prefer escaping early/returning null if Platform.OS !== 'android'

This revision is now accepted and ready to land.Sep 13 2023, 1:16 PM
This revision was landed with ongoing or failed builds.Sep 13 2023, 2:56 PM
This revision was automatically updated to reflect the committed changes.