Page MenuHomePhabricator

[native] Lift `floatingAction` to `ConnectedChatThreadList`

Authored by atul on Wed, Sep 13, 9:29 AM.



This diff is just one step in the process of converting ChatThreadList into a functional component. When this work is done, we will be able to avoid a lot of re-rendering and hopefully improve performance quite a bit.

NOTE: Also snuck in some cleanup to make diff where we merge into single component a bit more readable.

Depends on D9174

Test Plan

ChatThreadList + search experience continue to work as expected.

Diff Detail

rCOMM Comm
Lint Not Applicable
Tests Not Applicable

Event Timeline

atul published this revision for review.Wed, Sep 13, 9:37 AM

resolve merge conflicts and rebase

ginsu added inline comments.
551 ↗(On Diff #31071)

Nit: Would personally prefer escaping early/returning null if Platform.OS !== 'android'

This revision is now accepted and ready to land.Wed, Sep 13, 1:16 PM
This revision was landed with ongoing or failed builds.Wed, Sep 13, 2:56 PM
This revision was automatically updated to reflect the committed changes.