Page MenuHomePhabricator
Differential D9183

[native] Lift `floatingAction` to `ConnectedChatThreadList`
ClosedPublic
Actions

Authored by atul on Wed, Sep 13, 9:29 AM.

Details

Reviewers
ginsu
tomek
rohan
Commits
rCOMM423a7e9a095a: [native] Lift `floatingAction` to `ConnectedChatThreadList`
Summary

This diff is just one step in the process of converting ChatThreadList into a functional component. When this work is done, we will be able to avoid a lot of re-rendering and hopefully improve performance quite a bit.

NOTE: Also snuck in some cleanup to make diff where we merge into single component a bit more readable.

Depends on D9174

Test Plan

ChatThreadList + search experience continue to work as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Wed, Sep 13, 9:29 AM
Herald added a subscriber: ashoat. · View Herald TranscriptWed, Sep 13, 9:29 AM
atul edited the summary of this revision. (Show Details)Wed, Sep 13, 9:30 AM
atul published this revision for review.Wed, Sep 13, 9:37 AM
Harbormaster completed remote builds in B22596: Diff 31066.Wed, Sep 13, 9:47 AM
atul added a child revision: D9184: [native] Lift `FlatList` to `ConnectedChatThreadList`.Wed, Sep 13, 9:53 AM
atul updated this revision to Diff 31071.Wed, Sep 13, 9:59 AM

resolve merge conflicts and rebase

Harbormaster completed remote builds in B22601: Diff 31071.Wed, Sep 13, 10:19 AM
ginsu accepted this revision.Wed, Sep 13, 1:16 PM
ginsu added inline comments.
native/chat/chat-thread-list.react.js
551 ↗(On Diff #31071)

Nit: Would personally prefer escaping early/returning null if Platform.OS !== 'android'

This revision is now accepted and ready to land.Wed, Sep 13, 1:16 PM
atul updated this revision to Diff 31099.Wed, Sep 13, 2:51 PM

address @ginsu's feedback

This revision was landed with ongoing or failed builds.Wed, Sep 13, 2:56 PM
Closed by commit rCOMM423a7e9a095a: [native] Lift `floatingAction` to `ConnectedChatThreadList` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM423a7e9a095a: [native] Lift `floatingAction` to `ConnectedChatThreadList`.
Harbormaster completed remote builds in B22620: Diff 31099.Wed, Sep 13, 3:09 PM

Revision Contents
Changeset List

PathSize
native/
chat/
166 lines

Diff 31103

View Options

native/chat/chat-thread-list.react.js

Loading...