[native] Lift `hardwareBack` to `ConnectedChatThreadList`
ClosedPublic
Actions

Authored by atul on Sep 12 2023, 4:51 PM.

Details

Reviewers

ginsu
tomek
rohan

Commits

rCOMMbc069c45e99f: [native] Lift `hardwareBack` to `ConnectedChatThreadList`

Summary

This diff is just one step in the process of converting ChatThreadList into a functional component. When this work is done, we will be able to avoid a lot of re-rendering and hopefully improve performance quite a bit.

Depends on D9171

Test Plan

ChatThreadList + search experience continue to work as expected.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Sep 12 2023, 4:51 PM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 12 2023, 4:51 PM

atul published this revision for review.Sep 12 2023, 4:57 PM

atul added a child revision: D9173: [native] Lift `renderItem` to `ConnectedChatThreadList`.Sep 12 2023, 4:57 PM

Harbormaster completed remote builds in B22567: Diff 31017.Sep 12 2023, 5:09 PM

atul added a child revision: D9174: [native] Replace `listDataSelector` with `useMemo` in `ChatThreadList`.Sep 12 2023, 5:10 PM

atul removed a child revision: D9174: [native] Replace `listDataSelector` with `useMemo` in `ChatThreadList`.Sep 13 2023, 8:03 AM

ginsu accepted this revision.Sep 13 2023, 9:38 AM

This revision is now accepted and ready to land.Sep 13 2023, 9:38 AM

Closed by commit rCOMMbc069c45e99f: [native] Lift `hardwareBack` to `ConnectedChatThreadList` (authored by atul). · Explain WhySep 13 2023, 11:30 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMbc069c45e99f: [native] Lift `hardwareBack` to `ConnectedChatThreadList`.

Revision Contents
Changeset List

Path

Size

native/

chat/

chat-thread-list.react.js

39 lines

Diff 31087

View Options

native/chat/chat-thread-list.react.js

Show First 20 Lines • Show All 108 Lines • ▼ Show 20 Lines	function getUploadURL(id: string, secret: string): string {
if (isDev) {		if (isDev) {
const ipV4 = ip.v4.sync() \|\| 'localhost';		const ipV4 = ip.v4.sync() \|\| 'localhost';
const port = parseInt(process.env.PORT, 10) \|\| 3000;		const port = parseInt(process.env.PORT, 10) \|\| 3000;
return `http://${ipV4}:${port}${uploadPath}`;		return `http://${ipV4}:${port}${uploadPath}`;
}		}
return `${baseDomain}${uploadPath}`;		return `${baseDomain}${uploadPath}`;
}		}

function makeUploadURI(holder: ?string, id: string, secret: string): string {		function makeUploadURI(blobHash: ?string, id: string, secret: string): string {
if (holder) {		if (blobHash) {
return makeBlobServiceURI(holder);		return makeBlobServiceURI(blobHash);
}		}
return getUploadURL(id, secret);		return getUploadURL(id, secret);
}		}

function imagesFromRow(row: Object): Image \| EncryptedImage {		function imagesFromRow(row: Object): Image \| EncryptedImage {
const uploadExtra = JSON.parse(row.uploadExtra);		const uploadExtra = JSON.parse(row.uploadExtra);
const { width, height, blobHash, thumbHash } = uploadExtra;		const { width, height, blobHash, thumbHash } = uploadExtra;

▲ Show 20 Lines • Show All 280 Lines • Show Last 20 Lines

[native] Lift `hardwareBack` to `ConnectedChatThreadList`ClosedPublicActions