Page MenuHomePhabricator
Differential D9171

[native] Lift `onPressItem` and `onPressSeeMoreSidebars` to `ConnectedChatThreadList`
ClosedPublic
Actions

Authored by atul on Sep 12 2023, 3:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 5, 4:34 AM
Unknown Object (File)
Tue, Oct 1, 3:19 AM
Unknown Object (File)
Mon, Sep 30, 5:46 PM
Unknown Object (File)
Sat, Sep 28, 10:16 PM
Unknown Object (File)
Sat, Sep 28, 10:16 PM
Unknown Object (File)
Sat, Sep 28, 10:16 PM
Unknown Object (File)
Sat, Sep 28, 10:14 PM
Unknown Object (File)
Sat, Sep 28, 9:57 PM
View All 86 Files
Subscribers
ashoat

Details

Reviewers
ginsu
rohan
tomek
Commits
rCOMMd6827690bc41: [native] Lift `onPressItem` and `onPressSeeMoreSidebars` to…
Summary

This diff is just one step in the process of converting ChatThreadList into a functional component. When this work is done, we will be able to avoid a lot of re-rendering and hopefully improve performance quite a bit.

Depends on D9166

Test Plan

ChatThreadList + search experience continue to work as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Sep 12 2023, 3:59 PM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 12 2023, 3:59 PM
atul published this revision for review.Sep 12 2023, 3:59 PM
atul updated this revision to Diff 31016.Sep 12 2023, 4:03 PM

stage all

Harbormaster completed remote builds in B22565: Diff 31015.Sep 12 2023, 4:16 PM
Harbormaster completed remote builds in B22566: Diff 31016.Sep 12 2023, 4:20 PM
atul added a child revision: D9172: [native] Lift `hardwareBack` to `ConnectedChatThreadList`.Sep 12 2023, 4:51 PM
ginsu accepted this revision.Sep 13 2023, 9:36 AM
This revision is now accepted and ready to land.Sep 13 2023, 9:36 AM
Closed by commit rCOMMd6827690bc41: [native] Lift `onPressItem` and `onPressSeeMoreSidebars` to… (authored by atul). · Explain WhySep 13 2023, 11:30 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMd6827690bc41: [native] Lift `onPressItem` and `onPressSeeMoreSidebars` to….
ashoat mentioned this in D9991: [Flow202][native][skip-ci] [7/x] Fix leftover this keyword in ChatThreadList hook conversion.Nov 27 2023, 12:29 AM
ashoat mentioned this in rCOMM7623096b8bd2: [Flow202][native][skip-ci] [7/x] Fix leftover this keyword in ChatThreadList….Nov 27 2023, 3:27 PM

Revision Contents
Changeset List

PathSize
native/
chat/
64 lines

Diff 31088

View Options

native/chat/chat-thread-list.react.js

Loading...