Page MenuHomePhabricator

[Flow202][native][skip-ci] [59/x] Hide type error in crash reporting of ActionLogger
ClosedPublic

Authored by ashoat on Nov 27 2023, 1:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 6:41 AM
Unknown Object (File)
Oct 17 2024, 10:41 AM
Unknown Object (File)
Oct 17 2024, 10:41 AM
Unknown Object (File)
Oct 17 2024, 10:41 AM
Unknown Object (File)
Oct 17 2024, 10:41 AM
Unknown Object (File)
Sep 7 2024, 9:36 AM
Unknown Object (File)
Sep 6 2024, 1:47 AM
Unknown Object (File)
Sep 6 2024, 1:47 AM
Subscribers

Details

Summary

There's a type error here because ActionLogger doesn't understand the exact shape of the Redux state / actions it is passed. We could potentially fix this by adding some type parameters, but I didn't have the time while working on this.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10042

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable