Page MenuHomePhabricator

[Flow202][web][skip-ci] [16/x] Fix Flow issues in ChatInputBar.componentDidUpdate
ClosedPublic

Authored by ashoat on Nov 8 2023, 11:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 8, 2:47 AM
Unknown Object (File)
Tue, May 7, 3:50 AM
Unknown Object (File)
Mon, Apr 22, 3:53 PM
Unknown Object (File)
Tue, Apr 16, 4:43 PM
Unknown Object (File)
Mon, Apr 15, 8:48 PM
Unknown Object (File)
Apr 13 2024, 1:47 PM
Unknown Object (File)
Apr 13 2024, 8:27 AM
Unknown Object (File)
Apr 12 2024, 7:49 PM
Subscribers

Details

Summary

Flow is worried about side effects changing the values of these instance variables after they're checked.

To avoid the errors, I extract the instance variables to local variables before the checks.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9781

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2023, 12:05 PM
Harbormaster failed remote builds in B23930: Diff 32968!
This revision is now accepted and ready to land.Nov 9 2023, 3:13 AM
ashoat retitled this revision from [Flow202][web] [16/x] Fix Flow issues in ChatInputBar.componentDidUpdate to [Flow202][web][skip-ci] [16/x] Fix Flow issues in ChatInputBar.componentDidUpdate.Nov 19 2023, 5:03 PM
This revision was landed with ongoing or failed builds.Nov 27 2023, 3:26 PM
This revision was automatically updated to reflect the committed changes.