[Flow202][web][skip-ci] [10/x] Fix nonsensical use of selectors in ThreadPickerModal
ClosedPublic
Actions

Authored by ashoat on Nov 8 2023, 11:37 AM.

Details

Reviewers

ginsu
atul

Commits

rCOMM16500ff81540: [Flow202][web][skip-ci] [10/x] Fix nonsensical use of selectors in…

Summary

Was seeing Flow errors due to the createSelector usage. Opened the file and was deeply confused as to why createSelector and useSelector were used at all. See comments in D5317.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9775

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 8 2023, 11:37 AM

Herald added subscribers: will, tomek. · View Herald TranscriptNov 8 2023, 11:37 AM

ashoat added a child revision: D9777: [Flow202][web][skip-ci] [11/x] Fix Flow issues in selectors.Nov 8 2023, 11:38 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2023, 11:54 AM

Harbormaster failed remote builds in B23924: Diff 32962!

ashoat requested review of this revision.Nov 8 2023, 11:58 AM

ashoat mentioned this in D5317: [web] introduced thread-picker-modal.react.

thanks for fixing this

This revision is now accepted and ready to land.Nov 8 2023, 12:33 PM

ashoat retitled this revision from [Flow202][web] [10/x] Fix nonsensical use of selectors in ThreadPickerModal to [Flow202][web][skip-ci] [10/x] Fix nonsensical use of selectors in ThreadPickerModal.Nov 19 2023, 5:02 PM

This revision was landed with ongoing or failed builds.Nov 27 2023, 3:26 PM

Closed by commit rCOMM16500ff81540: [Flow202][web][skip-ci] [10/x] Fix nonsensical use of selectors in… (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM16500ff81540: [Flow202][web][skip-ci] [10/x] Fix nonsensical use of selectors in….