Page MenuHomePhabricator

[Flow202][lib][skip-ci] [8/23] Fix Flow issues in cookiesSelector
ClosedPublic

Authored by ashoat on Nov 4 2023, 12:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 10:49 PM
Unknown Object (File)
Sun, Oct 27, 10:33 PM
Unknown Object (File)
Sep 29 2024, 2:44 AM
Unknown Object (File)
Sep 29 2024, 2:12 AM
Unknown Object (File)
Sep 29 2024, 2:11 AM
Unknown Object (File)
Sep 28 2024, 9:56 PM
Unknown Object (File)
Sep 6 2024, 6:48 PM
Unknown Object (File)
Sep 6 2024, 6:33 PM
Subscribers

Details

Summary

The old version of Flow was treating the {} declaration as an "unsealed object", and as such was skipping typechecking it.

The new version of Flow doesn't do the "unsealed object" thing anymore, and forced me to annotate the declaration. That revealed a type error in cookiesSelector: the cookies in the returned object should be ?string, but were typed as string.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9699

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 4 2023, 12:18 PM
Harbormaster failed remote builds in B23742: Diff 32704!
This revision is now accepted and ready to land.Nov 7 2023, 4:41 AM
ashoat retitled this revision from [Flow202][lib] [8/23] Fix Flow issues in cookiesSelector to [Flow202][lib][skip-ci] [8/23] Fix Flow issues in cookiesSelector.Nov 19 2023, 11:46 AM
This revision was landed with ongoing or failed builds.Nov 27 2023, 3:25 PM
This revision was automatically updated to reflect the committed changes.